Skip to content

Commit

Permalink
🦉 Updates from OwlBot post-processor
Browse files Browse the repository at this point in the history
  • Loading branch information
gcf-owl-bot[bot] committed Feb 14, 2024
1 parent 4c761f5 commit ae2a1ac
Show file tree
Hide file tree
Showing 14 changed files with 152 additions and 324 deletions.
3 changes: 2 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ test/fixtures
build/
docs/
protos/
__snapshots__/
samples/generated/
system-test/**/fixtures
9 changes: 1 addition & 8 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "./node_modules/gts",
"rules": {
"@typescript-eslint/no-unused-vars": [
"error",
{"argsIgnorePattern": "^_", "varsIgnorePattern": "^_$"}
]
},
"root": true
"extends": "./node_modules/gts"
}
8 changes: 8 additions & 0 deletions .github/generated-files-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ generatedFiles:
message: '`.kokoro` files are templated and should be updated in [`synthtool`](https://github.com/googleapis/synthtool)'
- path: '.github/CODEOWNERS'
message: 'CODEOWNERS should instead be modified via the `codeowner_team` property in .repo-metadata.json'
- path: '.github/workflows/ci.yaml'
message: '`.github/workflows/ci.yaml` (GitHub Actions) should be updated in [`synthtool`](https://github.com/googleapis/synthtool)'
- path: '.github/generated-files-bot.+(yml|yaml)'
message: '`.github/generated-files-bot.(yml|yaml)` should be updated in [`synthtool`](https://github.com/googleapis/synthtool)'
- path: 'README.md'
message: '`README.md` is managed by [`synthtool`](https://github.com/googleapis/synthtool). However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml'
- path: 'samples/README.md'
message: '`samples/README.md` is managed by [`synthtool`](https://github.com/googleapis/synthtool). However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml'
ignoreAuthors:
- 'gcf-owl-bot[bot]'
- 'yoshi-automation'
6 changes: 1 addition & 5 deletions .github/release-please.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
handleGHRelease: true
manifest: true
branches:
- handleGHRelease: true
releaseType: node
branch: 12.x
releaseType: node
28 changes: 8 additions & 20 deletions .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
@@ -1,35 +1,23 @@
rebaseMergeAllowed: true
squashMergeAllowed: true
mergeCommitAllowed: false
branchProtectionRules:
- pattern: main
isAdminEnforced: false
isAdminEnforced: true
requiredApprovingReviewCount: 1
requiresCodeOwnerReviews: true
requiresStrictStatusChecks: true
requiredStatusCheckContexts:
- cla/google
- docs
- "ci/kokoro: Samples test"
- "ci/kokoro: System test"
- lint
- test (18)
- windows
- pattern: 12.x
isAdminEnforced: false
requiredApprovingReviewCount: 1
requiresCodeOwnerReviews: true
requiresStrictStatusChecks: true
requiredStatusCheckContexts:
- test (20)
- test (22)
- cla/google
- docs
- lint
- test (12)
- test (14)
- test (15)
- windows
- OwlBot Post Processor
permissionRules:
- team: yoshi-admins
permission: admin
- team: yoshi-nodejs-admins
- team: jsteam-admins
permission: admin
- team: yoshi-nodejs
- team: jsteam
permission: push
28 changes: 8 additions & 20 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [18, 20]
node: [18, 20, 22, 24]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
Expand All @@ -29,44 +29,32 @@ jobs:
windows:
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 14
- run: npm install
- run: npm test
env:
MOCHA_THROW_DEPRECATION: false
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 14
- run: npm install
- run: npm run lint
docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 14
- run: npm install
- run: npm run docs
- uses: JustinBeckwith/linkinator-action@v1
with:
paths: docs/
build-action:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
repository: google-github-actions/release-please-action
ref: main
- uses: actions/setup-node@v3
with:
node-version: 18
- run: npm install --save googleapis/release-please#${{ github.ref }}
- run: npm run build
2 changes: 1 addition & 1 deletion .kokoro/release/publish.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 15 additions & 7 deletions .kokoro/system-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 6 additions & 11 deletions .mocharc.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
// See the License for the specific language governing permissions and
// limitations under the License.
const config = {
'enable-source-maps': true,
'throw-deprecation': true,
timeout: 10000,
recursive: true,
};
"enable-source-maps": true,
"throw-deprecation": true,
"timeout": 10000,
"recursive": true
}
if (process.env.MOCHA_THROW_DEPRECATION === 'false') {
delete config['throw-deprecation'];
}
Expand All @@ -26,9 +26,4 @@ if (process.env.MOCHA_REPORTER) {
if (process.env.MOCHA_REPORTER_OUTPUT) {
config['reporter-option'] = `output=${process.env.MOCHA_REPORTER_OUTPUT}`;
}
process.on('unhandledRejection', err => {
console.error(err);
process.exit(1);
});

module.exports = config;
module.exports = config
24 changes: 24 additions & 0 deletions .nycrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
"**/apis",
"**/benchmark",
"**/conformance",
"**/docs",
"**/samples",
"**/scripts",
"**/protos",
"**/test",
"**/*.d.ts",
".jsdoc.js",
"**/.jsdoc.js",
"karma.conf.js",
"webpack-tests.config.js",
"webpack.config.js"
],
"exclude-after-remap": false,
"all": true
}
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ test/fixtures
build/
docs/
protos/
__snapshots__/
39 changes: 17 additions & 22 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,41 +39,36 @@ accept your pull requests.

### Before you begin

1. [Install Node.js LTS][node].
1. [Select or create a Cloud Platform project][projects].
1. [Set up authentication with a service account][auth] so you can access the
API from your local workstation.


## Running the tests

1. [Prepare your environment for Node.js setup][setup].

1. Install dependencies:

npm install

1. Run the tests:

# Run unit tests.
npm test

1. Lint (and maybe fix) any changes:

npm run fix

## Testing a new feature using CLI
# Run sample integration tests.
npm run samples-test

1. After you've written some new code, in order to test it out, you can use the [CLI][CLI].
# Run all system tests.
npm run system-test

The below command should be run from the root of the source code:
1. Lint (and maybe fix) any changes:

```
node build/src/bin/release-please.js release-pr \
--token=$GITHUB_TOKEN \
--repo-url=<owner>/<repo> [extra options]
```

It is equivalent to running the CLI command:
npm run fix

```
release-please release-pr \
--token=$GITHUB_TOKEN \
--repo-url=<owner>/<repo> [extra options]
```
[setup]: https://cloud.google.com/nodejs/docs/setup
[projects]: https://console.cloud.google.com/project
[billing]: https://support.google.com/cloud/answer/6293499#enable-billing

[node]: https://nodejs.org/en/
[CLI]: https://github.com/googleapis/release-please/blob/main/docs/cli.md/
[auth]: https://cloud.google.com/docs/authentication/getting-started
Loading

0 comments on commit ae2a1ac

Please sign in to comment.