Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ${component} without whitespace of the beginning #1626

Closed
tasshi-me opened this issue Sep 6, 2022 · 0 comments · Fixed by #2330
Closed

Provide ${component} without whitespace of the beginning #1626

tasshi-me opened this issue Sep 6, 2022 · 0 comments · Fixed by #2330
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tasshi-me
Copy link
Contributor

Hi there, and thank you for maintaining the great package.

Is your feature request related to a problem? Please describe.

Related to #1623.

I want to use ${component} as the scope of the commit message in pull-request-title-pattern.
e.g. chore(${component}): release ${version}

However the ${component} contains whitespace at the beginning of it.

Describe the solution you'd like

Remove whitespace of ${component}

Describe alternatives you've considered

Provide another template value that represents a component.

Additional context

The whitespace is added in:

const component = this.component ? ` ${this.component}` : '';

and parsed in:

.replace('${component}', ' ?(?<component>[\\w-./]*)?')

@tasshi-me tasshi-me added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
1 participant