-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce componentNoSpace
parameter (Removes whitespace character from ${component}
title pattern)
#2330
feat: Introduce componentNoSpace
parameter (Removes whitespace character from ${component}
title pattern)
#2330
Conversation
I would be interested that this PR will be merged. What else needs to happen for that? |
A stroke of luck that some maintainer sees this PR perhaps? I bet folks at google are busy but given the fact that last non-automated commit was made over 3 months ago it doesn't bode well 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, it will potentially visibly break users and disrupt parsing as the title does hold data for release-please.
Can we introduce a new template parameter (e.g. componentNoSpace
) and handle both? In the next major version, we can "fix" this by making the breaking change.
1db1fa1
to
8c0451b
Compare
${component}
componentNoSpace
parameter (Removes whitespace character from ${component}
title pattern)
componentNoSpace
parameter (Removes whitespace character from ${component}
title pattern) componentNoSpace
parameter (Removes whitespace character from ${component}
title pattern)
Hey, I've also tested it in a live repo, which you can see there: Below are the commands I used to bootstrap and test that repo CLI commandsrelease-please bootstrap --token=[REDACTED] --repo-url=Kiruyuto/rp-test --release-type=node npm run compile && node build/src/bin/release-please.js release-pr --token=[REDACTED] --repo-url=Kiruyuto/rp-test |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1626 🦕
Introduces new parameter (
(space) character from
componentNoSpace
) which removescomponent
effectively allowing to use component as a scope or in any other "complex" scenario, eg.:Prior to this change attempting to do so resulted in this kind of behaviour