Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expo requires Android's versionCode to be a integer (not a string) #1767

Closed
mrzmyr opened this issue Dec 4, 2022 · 3 comments · Fixed by #1770
Closed

Expo requires Android's versionCode to be a integer (not a string) #1767

mrzmyr opened this issue Dec 4, 2022 · 3 comments · Fixed by #1770
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mrzmyr
Copy link

mrzmyr commented Dec 4, 2022

When I try to build the application via Expo, I see this error:

Field: android.versionCode - should be integer.

For reference: versionCode - Expo Documentation

Seems like this can be easily fixed here:

release-please/src/updaters/expo/app-json.ts

Line 89 in 9cb84cb

parsed.expo.android.versionCode = versionCode.toString();

@mrzmyr mrzmyr added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 4, 2022
@mrzmyr mrzmyr changed the title Expo requires versionCode to be a integer (not a string) Expo requires Android's versionCode to be a integer (not a string) Dec 5, 2022
@mrzmyr mrzmyr mentioned this issue Dec 6, 2022
Closed
@JaccoGoris
Copy link
Contributor

Also running into this issue :)

@JaccoGoris JaccoGoris mentioned this issue Dec 7, 2022
Merged
4 tasks
@JaccoGoris
Copy link
Contributor

Hi, this fix is currently not coming through in the github action because that needs to be updated separately. or is there a different way I can start using it right now? thanks :)

@mrzmyr mrzmyr mentioned this issue Dec 8, 2022
Merged
@mrzmyr
Copy link
Author

mrzmyr commented Dec 8, 2022 •
edited
Loading

@JaccoGoris, the action is a different repo and needs to use the latest version. I created a PR: https://github.com/google-github-actions/release-please-action/pull/671

chingor13 pushed a commit to googleapis/release-please-action that referenced this issue Dec 8, 2022
@mrzmyr
fix: update release-please to 14.17.5 (#671)
4da3bc1 
- googleapis/release-please#1767
- googleapis/release-please#1770
- https://github.com/googleapis/release-please/releases/tag/v14.17.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: android version now correctly builds as a number JaccoGoris/release-please
3 participants
@chingor13 @mrzmyr @JaccoGoris