Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support TOML up to v1.0.0-rc.1 spec. #1837

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

BradenM
Copy link
Contributor

@BradenM BradenM commented Jan 30, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1836 🦕

This PR updates @iarna/toml the latest release of v3.0.0, which supports up to TOML v1.0.0-rc.1.

While it does not explicitly state support for v1.0.0, it is worth noting that all structrural changes were introduced in the rc.1 (namely, heterogeneous arrays).

For reference, you can see the test added in cf0a809 failing (w/o updating the lib) here:
https://github.com/BradenM/release-please/actions/runs/4040572970/jobs/6946340169#step:8:5167

…us arrays.

Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
@BradenM BradenM requested a review from a team as a code owner January 30, 2023 04:52
@BradenM BradenM requested a review from a team January 30, 2023 04:52
@google-cla
Copy link

google-cla bot commented Jan 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 30, 2023
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit a3d94ee into googleapis:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOML v1.0.0 spec is not supported.
2 participants