Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scan readme files in java-yoshi-mono-repo strategy #1853

Merged
merged 5 commits into from
Feb 15, 2023
Merged

feat: Scan readme files in java-yoshi-mono-repo strategy #1853

merged 5 commits into from
Feb 15, 2023

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Feb 14, 2023 •
edited
Loading

Local run working as expected -> ddixit14/google-cloud-java#9

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 14, 2023
@ddixit14 ddixit14 marked this pull request as ready for review February 14, 2023 20:03
@ddixit14 ddixit14 requested review from a team as code owners February 14, 2023 20:03
@suztomo
Copy link
Member

suztomo commented Feb 15, 2023 •
edited
Loading

Is it possible to add new test assertion(s) that README.md is indeed updated (test/strategies/java-yoshi-mono-repo.ts)?

@chingor13 chingor13 merged commit 635cc7d into main Feb 15, 2023
@chingor13 chingor13 deleted the readme-update branch February 15, 2023 18:22
@release-please release-please bot mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@suztomo suztomo suztomo approved these changes

Assignees

@chingor13 chingor13

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddixit14 @suztomo @chingor13