Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define multiple paths #1921

Open
mvrana-cen81948 opened this issue Apr 12, 2023 · 4 comments · May be fixed by #2336
Open

Ability to define multiple paths #1921

mvrana-cen81948 opened this issue Apr 12, 2023 · 4 comments · May be fixed by #2336
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mvrana-cen81948
Copy link

mvrana-cen81948 commented Apr 12, 2023

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
I am missing option to define paths whićh may be considered to scan commits. E.G. i have project with structure

  • core
  • features
  • shared
  • demo
    i want scan paths /core, /features, /shared and exclude /demo.

Also with monorepo approach:

  • apps

    • app1
    • app2
  • libs

    • lib1
    • lib2
    • shared

app1 uses code from lib1, shared, app2 uses code from lib2, shared. Theese libs are not standalone libs, it is just separation of code from app. So i do not need track changes for every separate lib, but i want include it with app. So in manifest i have only app1 and app2

Describe the solution you'd like
path should accept multiple paths separated by comma

Describe alternatives you've considered
I tried many trick like filtering repository using monorepo dependency tree and also another versoning plugins fox NX monorpo. But release-please fits best with PR approach, except this single feature missing

Another solution: let current attribute path as is and add another one: additionalPaths: string[] which accepts another paths from root of repository

Additional context
Add any other context or screenshots about the feature request here.

@mvrana-cen81948 mvrana-cen81948 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 12, 2023
@flavio1110
Copy link

Same here. We have a very similar setup with a monorepo with Apps depending on libs defined on the repo itself.

We face the same issue that the release is only triggered for the specified paths, and we can't specify what paths to watch for too.

@tamusil-cen55253
Copy link

Same for us. Some news?

@AlbertHernandez
Copy link

Some update? I have the same use case and it would be super great to have this feature

@jack-lewin
Copy link

Hey @chingor13 - would you accept contributions for this feature request?

I'd like to add support to the manifest releaser, for example if we want to trigger a release in apps/my-app-2 when commits are found in libs/my-lib:

apps/
    my-app-1
    my-app-2
libs/
    my-lib
{
  "packages": {
    "apps/my-app-1": {},
    "apps/my-app-2": {
      "additional-paths": ["libs/my-lib"] // additional-paths would be a new config option
    }
  }
}

@jack-lewin jack-lewin linked a pull request Jul 13, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants