-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional-paths property to manifest releaser #2336
base: main
Are you sure you want to change the base?
Conversation
Before, packagePaths was an array of strings, i.e. the name of each package. Now, packagePaths is a Record<string, string[]>, with the key being the name of each package, and the value being an aray of additionalPaths for that package.
Hi @chingor13, sorry for the nudge - are you still maintaining this project? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this and sorry for the delay in reviewing.
This mostly looks fine although we should explicitly define what the expected logic is if an additional path coincides with a different component's path or additional paths. Currently, we sort by the components' path length with the longest first as a way to prefer the deepest path in the case of overlapping paths. With this new logic, we are still sorting based on the main path, and preferring its additional paths over any other ones.
Instead, we may need to invert the mapping and have the keys be all the "paths" (main & additional) and the value is the main component path to associate to.
Hi @jack-lewin will you have time to update your PR or do you need help ? Thank you for this PR |
sync with the latest main: jack-lewin#1 |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1921 🦕
This PR adds an
additional-paths
property to the manifest releaser.Additional paths are useful for monorepos where a package might depend files from other directories.
For example, if we want to trigger a release in
apps/my-app-2
when commits are found inlibs/my-lib
:Best reviewed commit-by-commit.