Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge latest main #1

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

merge latest main #1

wants to merge 28 commits into from

Conversation

roivanov
Copy link

@roivanov roivanov commented Oct 4, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

goatwu1993 and others added 28 commits September 11, 2024 09:34
Co-authored-by: Jeff Ching <chingor@google.com>
…extraFiles (googleapis#2344)

Co-authored-by: Jeff Ching <chingor@google.com>
Signed-off-by: Ketil Gjerde <477141+mysteq@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
…s#2283)

fixes googleapis#2282

Co-authored-by: Jeff Ching <chingor@google.com>
googleapis#2331)

* docs: update manifest-releaser docs to add some clarification around the package path

- make it a little clearer that the package path should be a folder and not a file
- give an example for creating an empty release-please-manifest.json

Signed-off-by: Amo Chumber <amo@sysadmiral.xyz>

* Update manifest-releaser.md

---------

Signed-off-by: Amo Chumber <amo@sysadmiral.xyz>
Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: Jeff Ching <chingor@google.com>
…googleapis#2323)

* docs: add compile step to local run command

* fix: prevent open release PRs from being mistaken as current releases

---------

Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Jeff Ching <chingor@google.com>
…erged with `autorelease:closed` (googleapis#2255)

* doc: Update troubleshooting.md

* Update troubleshooting.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
…acter from `${component}` title pattern) (googleapis#2330)

* fix: Remove space from pull-request-title.ts

* test: Fix failing tests

* feat: Introduce new parameter `componentNoSpace`; Partially revert previous changes

* feat: Update docs

* chore: Remove unnecessary `console.log()`

* style: Run `npm fix` across the project

* chore: Update snapshots

* feat: Add `componentNoSpace` parameter to merge plugin

* style: Adjust code style; Run `npm fix`

* fix: Docs parameter name
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: handle multiple commits in a single message

- updated `splitMessages` function to handle multiple conventional commits within the main message
- added logic to separate conventional commits (feat, fix, docs, etc.) within the main message
- preserved the original message structure outside of nested commit blocks
- enhanced breaking change detection from commit body in `toConventionalChangelogFormat` and `postProcessCommits` functions

Resolves googleapis#2357

* test: new test case for parsing multiple commits

- added new test cases for parsing multiple commits from a single message
- added fixture file for multiple commits in a single message
- changed the order of the expected commits in `multiple-messages` and `1257-breaking-change` fixtures since the order of the commits in the is not reversed anymore

* test: remove duplicate test for parsing multiple commits
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…ewlines (googleapis#2390)

* fix: when parsing multiple messages from a single commit, require 2 newlines

* test: fix test name

* try optional windows newlines
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…pis#2310)

* fix merging behaviour in plugin

* add test

* remove unused test snapshot

* update licnese header

* considering plugin schema carefully

* add unit test

* remove `determineMerge` and set default value directly

* set default value for `separatePullRequests` in `buildPlugin`

---------

Co-authored-by: Jeff Ching <chingor@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.