Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect signoff in manifest config #2334

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

mysteq
Copy link
Contributor

@mysteq mysteq commented Jul 11, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2333 and #2280 🦕

Changes the implementation of #2246 since signoff is only applicapbe to root in manifest config.

Output of debug-config after PR

...
separatePullRequests: true,
fork: false,
signoffUser: 'foo <foo@users.noreply.github.com>',
releaseLabels: [ 'autorelease: tagged' ],
labels: [ 'autorelease: pending' ],
...

Signed-off-by: Ketil Gjerde <477141+mysteq@users.noreply.github.com>
@mysteq mysteq requested review from a team as code owners July 11, 2024 12:11
Copy link

google-cla bot commented Jul 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 11, 2024
@chingor13 chingor13 merged commit eb968c8 into googleapis:main Sep 11, 2024
11 checks passed
@mysteq mysteq deleted the fix/adheresignoff branch September 11, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to configure signoff commits in config
2 participants