Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to signoff commits from config #2246

Closed
shanduur opened this issue Mar 16, 2024 · 0 comments · Fixed by #2247
Closed

Unable to signoff commits from config #2246

shanduur opened this issue Mar 16, 2024 · 0 comments · Fixed by #2247
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@shanduur
Copy link
Contributor

shanduur commented Mar 16, 2024 •
edited
Loading

Environment details

  • OS: ubuntu-latest
  • Node.js version: N/A (run via release-please-action GitHub Action)
  • npm version: N/A (run via release-please-action GitHub Action)
  • release-please version: N/A (run via release-please-action GitHub Action)

Steps to reproduce

  1. Add $.signoff to config as per documentation of release-please-action
{
  "signoff": "foo <foo@users.noreply.github.com>",
  "packages": {
    ".": {
      "release-type": "simple"
    }
  }
}
  1. Run release-please

This issue is related to https://github.com/google-github-actions/release-please-action/issues/904 (thanks @geemanjs for the investigation!).
@shanduur shanduur added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 16, 2024
@shanduur shanduur mentioned this issue Mar 16, 2024
Merged
4 tasks
This was referenced Jul 11, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: respect signoff in config shanduur/release-please
2 participants
@chingor13 @shanduur