Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to configure signoff commits in config #2333

Closed
mysteq opened this issue Jul 11, 2024 · 0 comments · Fixed by #2334
Closed

Unable to configure signoff commits in config #2333

mysteq opened this issue Jul 11, 2024 · 0 comments · Fixed by #2334
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mysteq
Copy link
Contributor

mysteq commented Jul 11, 2024

Environment details

  • OS: ubuntu-latest
  • Node.js version: N/A (run via release-please-action GitHub Action)
  • npm version: N/A (run via release-please-action GitHub Action)
  • release-please version: 16.12.0 (run via release-please-action GitHub Action)

Steps to reproduce

  1. Add $.signoff to config as per documentation of release-please-action
{
  "signoff": "foo <foo@users.noreply.github.com>",
  "packages": {
    ".": {
      "release-type": "simple"
    }
  }
}
  1. Run release-please

  2. Example relevant output from debug-config

....
separatePullRequests: true,
fork: false,
signoffUser: undefined,
releaseLabels: [ 'autorelease: tagged' ],
labels: [ 'autorelease: pending' ],
....

This issue is related to https://github.com/google-github-actions/release-please-action/issues/904 and also seems to have been tried to be solved here #2246 .

@mysteq mysteq added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants