Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect signoff in manifest config #2334

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: respect signoff in manifest config #2334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c83ae2
fix: respect signoff in manifest config
mysteq Jul 11, 2024
4203959
Merge branch 'main' into fix/adheresignoff
chingor13 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions schemas/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,10 @@
]
}
},
"signoff": {
"description": "Text to be used as Signed-off-by in the commit.",
"type": "string"
},
"group-pull-request-title-pattern": {
"description": "When grouping multiple release pull requests use this pattern for the title.",
"type": "string"
Expand Down Expand Up @@ -431,6 +435,7 @@
"last-release-sha": true,
"always-link-local": true,
"plugins": true,
"signoff": true,
"group-pull-request-title-pattern": true,
"release-search-depth": true,
"commit-search-depth": true,
Expand Down
5 changes: 2 additions & 3 deletions src/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ export interface ReleaserConfig {
releaseLabels?: string[];
extraLabels?: string[];
initialVersion?: string;
signoff?: string;

// Changelog options
changelogSections?: ChangelogSection[];
Expand Down Expand Up @@ -161,7 +160,6 @@ interface ReleaserConfigJson {
'changelog-sections'?: ChangelogSection[];
'release-as'?: string;
'skip-github-release'?: boolean;
signoff?: string;
draft?: boolean;
prerelease?: boolean;
'draft-pull-request'?: boolean;
Expand Down Expand Up @@ -255,6 +253,7 @@ export interface ManifestConfig extends ReleaserConfigJson {
'last-release-sha'?: string;
'always-link-local'?: boolean;
plugins?: PluginType[];
signoff?: string;
'group-pull-request-title-pattern'?: string;
'release-search-depth'?: number;
'commit-search-depth'?: number;
Expand Down Expand Up @@ -1372,7 +1371,6 @@ function extractReleaserConfig(
skipSnapshot: config['skip-snapshot'],
initialVersion: config['initial-version'],
excludePaths: config['exclude-paths'],
signoff: config['signoff'],
};
}

Expand Down Expand Up @@ -1417,6 +1415,7 @@ async function parseConfig(
separatePullRequests: config['separate-pull-requests'],
groupPullRequestTitlePattern: config['group-pull-request-title-pattern'],
plugins: config['plugins'],
signoff: config['signoff'],
labels: configLabel?.split(','),
releaseLabels: configReleaseLabel?.split(','),
snapshotLabels: configSnapshotLabel?.split(','),
Expand Down
Loading