Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support-node-workspace-plugin-prerelease #2249

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Animalmix55
Copy link
Contributor

@Animalmix55 Animalmix55 commented Mar 19, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2248 🦕

@Animalmix55 Animalmix55 requested review from a team as code owners March 19, 2024 01:04
Copy link

google-cla bot commented Mar 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 19, 2024
@Animalmix55
Copy link
Contributor Author

@chingor13 tested and validated using my local branch of https://github.com/Seekr-io/release-please-action

@tada5hi
Copy link
Contributor

tada5hi commented Mar 22, 2024

@Animalmix55 shouldn't the version be incremented to x.x.x-beta.x instead of x.x.x-beta ?

@Animalmix55
Copy link
Contributor Author

Animalmix55 commented Mar 22, 2024

@Animalmix55 shouldn't the version be incremented to x.x.x-beta.x instead of x.x.x-beta ?

The initial prerelease comes with no .#, subsequent prereleases begin appending and iterating the .#.

I did not make any changes to the way that the prerelease version strategy operates, but I don’t disagree that it’s a bit unexpected. It appears you could make this happen by specifying a prerelease type of beta.1 since the prerelease type of the previous version is persisted on future bumps.

Copy link
Contributor

@niieani niieani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hope this gets merged!

@ianpilipski-pf
Copy link

I'm also interested in this fix, is there any way to get it approved/merged?

@chingor13 chingor13 closed this Sep 11, 2024
@chingor13 chingor13 reopened this Sep 11, 2024
@chingor13
Copy link
Contributor

chingor13 commented Sep 11, 2024

I need to be able to rebase/update from main to merge this. Can you either rebase/merge from main or enable the "Maintainer may modify" checkbox?

Edit: I'm able to enable/use the merge queue feature

@chingor13 chingor13 added this pull request to the merge queue Sep 11, 2024
Merged via the queue into googleapis:main with commit 88dc416 Sep 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node-Workspaces plugin doesn't obey pre-release versioning strategy
5 participants