-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support-node-workspace-plugin-prerelease #2249
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@chingor13 tested and validated using my local branch of https://github.com/Seekr-io/release-please-action |
@Animalmix55 shouldn't the version be incremented to |
The initial prerelease comes with no .#, subsequent prereleases begin appending and iterating the .#. I did not make any changes to the way that the prerelease version strategy operates, but I don’t disagree that it’s a bit unexpected. It appears you could make this happen by specifying a prerelease type of beta.1 since the prerelease type of the previous version is persisted on future bumps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Hope this gets merged!
I'm also interested in this fix, is there any way to get it approved/merged? |
I need to be able to rebase/update from main to merge this. Can you either rebase/merge from main or enable the "Maintainer may modify" checkbox? Edit: I'm able to enable/use the merge queue feature |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2248 🦕