Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-Workspaces plugin doesn't obey pre-release versioning strategy #2248

Closed
Animalmix55 opened this issue Mar 19, 2024 · 0 comments · Fixed by #2249
Closed

Node-Workspaces plugin doesn't obey pre-release versioning strategy #2248

Animalmix55 opened this issue Mar 19, 2024 · 0 comments · Fixed by #2249
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Animalmix55
Copy link
Contributor

Thanks for stopping by to let us know something could be better!

Please provide the following details.

Environment details

Github actions via https://github.com/google-github-actions/release-please-action@v4

Steps to reproduce

  1. Create a node root package inside of a GitHub repo
  2. Create two workspaces under that package called @test/package-1 and @test/package-2 at packages/package-1 and packages/package-2, respectively
  3. Add a dependency on @test/package-1 to @test/package-2
  4. Bootstrap release-please and add both packages to the config file with the following config:
{
    "versioning": "prerelease",
    "prerelease": true,
    "prerelease-type": "alpha"
}
  1. Configure the repo to use release-please-action@v4 on main as described by (https://github.com/google-github-actions/release-please-action)
  2. Update a file in @test/package-1 to trigger a release PR creation
  3. Notice that only @test/package-1 has a pre-release version, @test/package-2 has an updated but not pre-release version.

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

@Animalmix55 Animalmix55 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants