Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix comment at release pr is ugly #2348

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: fix comment at release pr is ugly #2348

merged 2 commits into from
Sep 11, 2024

Conversation

goatwu1993
Copy link
Contributor

@goatwu1993 goatwu1993 commented Aug 2, 2024 •
edited by chingor13
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

the :robot: is replaced with 🤖 intentionally. Otherwise the trailing colon must be removed

Fixes #2347 🦕

@goatwu1993 goatwu1993 requested review from a team as code owners August 2, 2024 08:08
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 2, 2024
@goatwu1993 goatwu1993 force-pushed the chore/fix-release-comment-ugly branch from c287d58 to e5fb5d4 Compare August 2, 2024 08:11
@chingor13 chingor13 merged commit e562ee2 into googleapis:main Sep 11, 2024
11 checks passed
@release-please release-please bot mentioned this pull request Sep 11, 2024
Merged
@chingor13 chingor13 mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release comment at release pr is ugly
2 participants
@goatwu1993 @chingor13