Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update manifest-releaser docs to add some clarification around … #2331

Merged

Conversation

sysadmiral
Copy link
Contributor

…the package path

  • make it a little clearer that the package path should be a folder and not a file
  • give an example for creating an empty release-please-manifest.json

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2325 🦕

@sysadmiral sysadmiral requested review from a team as code owners July 9, 2024 12:52
Copy link

google-cla bot commented Jul 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 9, 2024
…the package path

- make it a little clearer that the package path should be a folder and not a file
- give an example for creating an empty release-please-manifest.json

Signed-off-by: Amo Chumber <amo@sysadmiral.xyz>
@sysadmiral sysadmiral force-pushed the add_clarification_around_package_path branch from 63365c6 to d5994b5 Compare August 10, 2024 06:20
@chingor13 chingor13 merged commit a4bbce1 into googleapis:main Sep 11, 2024
11 checks passed
@sysadmiral sysadmiral deleted the add_clarification_around_package_path branch September 26, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can a component be a single file?
2 participants