Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use strategies for cargo workspace plugin (rust) #2320

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: use strategies for cargo workspace plugin (rust) #2320

merged 2 commits into from
Sep 11, 2024

Conversation

bukowa
Copy link
Contributor

@bukowa bukowa commented Jun 25, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2318 🦕

Basically copied code from #2112

@bukowa bukowa requested review from a team as code owners June 25, 2024 19:06
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jun 25, 2024
@bukowa bukowa changed the title fix: use strategies for rust workspace plugin fix: use strategies for cargo workspace plugin (rust) Jun 25, 2024
bukowa added a commit to bukowa/ck3oop that referenced this pull request Jun 26, 2024
@bukowa
tools(release): add justfile recipe to run release-please with cu…
484540d 
…stom git patches

googleapis/release-please#2320

Signed-off-by: Bukowa <gitbukowa@gmail.com>
bukowa added a commit to bukowa/ck3oop that referenced this pull request Jun 26, 2024
@bukowa
tools(release): add justfile recipe to run release-please with cu…
147af64 
…stom git patches

googleapis/release-please#2320

Signed-off-by: Bukowa <gitbukowa@gmail.com>
@chingor13
Copy link
Contributor

Closing and reopening to trigger CI

@chingor13 chingor13 closed this Sep 11, 2024
@chingor13 chingor13 reopened this Sep 11, 2024
@chingor13 chingor13 added this pull request to the merge queue Sep 11, 2024
Merged via the queue into googleapis:main with commit 427db6d Sep 11, 2024
11 checks passed
@release-please release-please bot mentioned this pull request Sep 11, 2024
Merged
@chingor13 chingor13 mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo-workspace - package missing version header in changelog when only dependency is updated
2 participants
@bukowa @chingor13