Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: print error message of unparsed commits #2326

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

aabouzaid
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2298


The easiest solution to issue no. #2298 is to print the caught error message.
I had an issue with release-please and I couldn't get more about it till I printed the error.

Copy link

google-cla bot commented Jul 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 3, 2024
Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>
@aabouzaid aabouzaid force-pushed the 2298-print-unparsed-commit-error branch from 098840d to 52d9070 Compare July 3, 2024 19:59
@aabouzaid aabouzaid marked this pull request as ready for review July 3, 2024 20:11
@aabouzaid aabouzaid requested review from a team as code owners July 3, 2024 20:11
@chingor13 chingor13 merged commit 83eb3e4 into googleapis:main Sep 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More detailed "commit could not be parsed" error message
2 participants