Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed "commit could not be parsed" error message #2298

Closed
twalshOG opened this issue May 29, 2024 · 0 comments · Fixed by #2326
Closed

More detailed "commit could not be parsed" error message #2298

twalshOG opened this issue May 29, 2024 · 0 comments · Fixed by #2326
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@twalshOG
Copy link

Is your feature request related to a problem? Please describe.
When a merged PR could not be scanned it is difficult to figure out why.
Describe the solution you'd like
Ideally instead of just returning sha and commit message it would be nice to also get a more detailed explanation of why it could not be parsed.
I see this as on debug logging (core.debug) option in https://github.com/googleapis/release-please-action, like here

Describe alternatives you've considered
Add error message to logger:

    } catch (err) {
      logger.debug(
        `commit could not be parsed: ${commit.sha} ${
          commit.message.split('\n')[0]
        } - ${(err as Error).message}`
@twalshOG twalshOG added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 29, 2024
github-merge-queue bot pushed a commit to kurtosis-tech/kurtosis that referenced this issue Oct 31, 2024
Should give more verbose info on the current problem with:

> commit could not be parsed: b36ddc9
fix: handle no docker auth and log only a warning when getting auth
credentials fails (#2579)

As per googleapis/release-please#2298

---------

Co-authored-by: Tedi Mitiku <tedi.m52@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants