Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release-please fails to parse commit messages with code samples #2272

Open
OrKoN opened this issue Apr 16, 2024 · 1 comment
Open

Release-please fails to parse commit messages with code samples #2272

OrKoN opened this issue Apr 16, 2024 · 1 comment
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@OrKoN
Copy link
Contributor

OrKoN commented Apr 16, 2024

Environment details

  • OS: all
  • Node.js version: 20
  • npm version: 10.2.4
  • release-please version: 14.17.2

Steps to reproduce

  1. See test: add a test for parsing commit messages with code #2271
@OrKoN OrKoN added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 16, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 16, 2024
@OrKoN OrKoN mentioned this issue Apr 16, 2024
Open
@chingor13
Copy link
Contributor

From the logging added in #2326, we can see that it's failing on the second (. This is throwing an error from the upstream @conventional-commits/parser library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chingor13 @OrKoN