Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The previous tag name does not respect custom tagSeparator and/or includeVInTag: false in the generated PR #2282

Closed
niieani opened this issue May 5, 2024 · 0 comments · Fixed by #2283, #2376 or googleapis/repo-automation-bots#5511
Closed

The previous tag name does not respect custom tagSeparator and/or includeVInTag: false in the generated PR #2282

niieani opened this issue May 5, 2024 · 0 comments · Fixed by #2283, #2376 or googleapis/repo-automation-bots#5511
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@niieani
Copy link
Contributor

niieani commented May 5, 2024 •
edited
Loading

PR with a fix: #2283

Environment details

  • OS: macOS 14.4.1 (23E224)
  • Node.js version: v21.1.0
  • npm version: 10.7.0
  • release-please version: 16.10.2

Steps to reproduce

  1. set a custom, e.g. tagSeparator: "@" and/or includeVInTag: false
  2. run release-please release-pr from CLI (or via the Github Action)

The created PR will generate the following URL for each version of a release:

https://github.com/org/package/compare/package-v1.0.0...package@1.0.1
                                       ^^^^^^^^^^^^^^

As you can see:

  • the 1st tag name is incorrect: package-v1.0.1 - does not respect neither tagSeparator nor includeVInTag setting
  • the 2nd tag name is correct: package@1.0.1 - respects tagSeparator: "@" and includeVInTag: false
See screenshot Screenshot 2024-05-04 at 19 31 33
@niieani niieani added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 5, 2024
niieani added a commit to niieani/release-please that referenced this issue May 5, 2024
@niieani
fix: respect tagSeparator and includeVInTag everywhere
3c69fed 
fixes googleapis#2282
@niieani niieani mentioned this issue May 5, 2024
Merged
4 tasks
@release-please release-please bot mentioned this issue Sep 11, 2024
Merged
@chingor13 chingor13 mentioned this issue Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@chingor13 @niieani