fix: respect tagSeparator and includeVInTag everywhere (#2283)

fixes #2282 Co-authored-by: Jeff Ching <chingor@google.com>
googleapis · Sep 11, 2024 · dad27e3 · dad27e3
1 parent acc3242
commit dad27e3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/manifest.ts b/src/manifest.ts
@@ -687,7 +687,12 @@ export class Manifest {
           `No latest release found for path: ${path}, component: ${component}, but a previous version (${version.toString()}) was specified in the manifest.`
         );
         releasesByPath[path] = {
-          tag: new TagName(version, component),
+          tag: new TagName(
+            version,
+            component,
+            this.repositoryConfig[path].tagSeparator,
+            this.repositoryConfig[path].includeVInTag
+          ),
           sha: '',
           notes: '',
         };

diff --git a/src/strategies/php-yoshi.ts b/src/strategies/php-yoshi.ts
@@ -101,7 +101,12 @@ export class PHPYoshi extends BaseStrategy {
     const versionsMap: VersionsMap = new Map();
     const directoryVersionContents: Record<string, ComponentInfo> = {};
     const component = await this.getComponent();
-    const newVersionTag = new TagName(newVersion, component);
+    const newVersionTag = new TagName(
+      newVersion,
+      component,
+      this.tagSeparator,
+      this.includeVInTag
+    );
     let releaseNotesBody = `## ${newVersion.toString()}`;
     for (const directory of topLevelDirectories) {
       try {