Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use regex to replace version in GenericJSON updater #2253

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

0xdbe
Copy link
Contributor

@0xdbe 0xdbe commented Mar 28, 2024

Description

This PR fixes some issues in GenericJSON Updater:

  • Update only if matching element is a string. If matching element is an array, it will not be override by the version number, but simply skipped.
  • Update only the version number found in the string. Not all content in the matched element will be replaced with the version number.

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2244 🦕

@0xdbe 0xdbe requested review from a team as code owners March 28, 2024 21:23
Copy link

google-cla bot commented Mar 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 28, 2024
@chingor13 chingor13 merged commit acc3242 into googleapis:main Sep 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic JSON updater can't replace version in a string field
2 participants