feat: fallback to root package version if package ignores github release #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
approved these changes
Sep 7, 2023
kalosisz
added a commit
to kalosisz/release-please
that referenced
this pull request
Sep 19, 2023
chore(deps): update actions/checkout action to v4 (googleapis#2060) docs: check `autorelease: pending` or `autorelease: triggered` in an old PR (googleapis#1930) * docs: check `autorelease: pending` or `autorelease: triggered` in an old PR In googleapis/java-logging-logback#1050, I had to remove the "autorelease: pending " label to create a release pull request. * Update README.md fix mismerge --------- Co-authored-by: Jeff Ching <chingor@google.com> test: also test on node 18 (googleapis#2063) * test: also test on node 18 * ci: enable no-experimental-fetch for tests * ci: set NODE_OPTIONS for node 18 * set NODE_OPTIONS for windows build * set NODE_OPTIONS for windows build ci: only require node 18 tests (googleapis#2065) feat!: require node 18+ (googleapis#2069) fix(deps): bump semver dependency version (googleapis#2068) feat: Support pnpm workspaces (googleapis#2058) fix(deps): replace lerna dependency with lerna-lite Co-authored-by: Jeff Ching <chingor@google.com> fix(deps): upgrade http-proxy-agent to v7 (googleapis#2071) fix(deps): upgrade https-proxy-agent to v7 feat: fallback to root package version if package ignores github release (googleapis#1935) Co-authored-by: Jeff Ching <chingor@google.com> chore(deps): update dependency sinon to v16 (googleapis#2079) feat: Use default updaters based on file extension (googleapis#2072) * feat: Use default updaters based on file extension * use CompositeUpdater * improve things --------- Co-authored-by: Jeff Ching <chingor@google.com> chore(main): release 16.0.0 (googleapis#2070) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> config docs
kalosisz
added a commit
to kalosisz/release-please
that referenced
this pull request
Sep 19, 2023
chore(deps): update actions/checkout action to v4 (googleapis#2060) docs: check `autorelease: pending` or `autorelease: triggered` in an old PR (googleapis#1930) * docs: check `autorelease: pending` or `autorelease: triggered` in an old PR In googleapis/java-logging-logback#1050, I had to remove the "autorelease: pending " label to create a release pull request. * Update README.md fix mismerge --------- Co-authored-by: Jeff Ching <chingor@google.com> test: also test on node 18 (googleapis#2063) * test: also test on node 18 * ci: enable no-experimental-fetch for tests * ci: set NODE_OPTIONS for node 18 * set NODE_OPTIONS for windows build * set NODE_OPTIONS for windows build ci: only require node 18 tests (googleapis#2065) feat!: require node 18+ (googleapis#2069) fix(deps): bump semver dependency version (googleapis#2068) feat: Support pnpm workspaces (googleapis#2058) fix(deps): replace lerna dependency with lerna-lite Co-authored-by: Jeff Ching <chingor@google.com> fix(deps): upgrade http-proxy-agent to v7 (googleapis#2071) fix(deps): upgrade https-proxy-agent to v7 feat: fallback to root package version if package ignores github release (googleapis#1935) Co-authored-by: Jeff Ching <chingor@google.com> chore(deps): update dependency sinon to v16 (googleapis#2079) feat: Use default updaters based on file extension (googleapis#2072) * feat: Use default updaters based on file extension * use CompositeUpdater * improve things --------- Co-authored-by: Jeff Ching <chingor@google.com> chore(main): release 16.0.0 (googleapis#2070) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> config docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea that if we have umbrella package
.and one of the packages configured in manifest does not have a github release then latest release is the release from umbrella package.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1934 🦕