Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback to root package version if package ignores github release #1935

Merged
merged 9 commits into from
Sep 12, 2023
28 changes: 28 additions & 0 deletions src/manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,34 @@ export class Manifest {
sha: foundTag.sha,
notes: '',
};
} else {
if (
strategiesByPath[ROOT_PROJECT_PATH] &&
this.repositoryConfig[path].skipGithubRelease
) {
this.logger.debug('could not find release, checking root package');
const rootComponent = await strategiesByPath[
ROOT_PROJECT_PATH
].getComponent();
const rootTag = new TagName(
expectedVersion,
rootComponent,
this.repositoryConfig[ROOT_PROJECT_PATH].tagSeparator,
this.repositoryConfig[ROOT_PROJECT_PATH].includeVInTag
);
const foundTag = allTags[rootTag.toString()];
if (foundTag) {
this.logger.debug(
`found rootTag: ${foundTag.name} ${foundTag.sha}`
);
releasesByPath[path] = {
name: foundTag.name,
tag: rootTag,
sha: foundTag.sha,
notes: '',
};
}
}
}
}
return releasesByPath;
Expand Down