Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasable units always use version from pull request title during manifest release #2101

Closed
axieum opened this issue Oct 19, 2023 · 1 comment · Fixed by #2102 or #2107
Closed

Releasable units always use version from pull request title during manifest release #2101

axieum opened this issue Oct 19, 2023 · 1 comment · Fixed by #2102 or #2107
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@axieum
Copy link
Contributor

axieum commented Oct 19, 2023 •
edited
Loading

Environment details

  • OS: Ubuntu 22.04.3
  • Node.js version: 12
  • npm version:
  • release-please version: GoogleCloudPlatform/release-please-action@v3 (SHA:4c5670f886fe259db4d11222f7dff41c1382304d)

Steps to reproduce

Affected run: https://github.com/axieum/minecord/actions/runs/6575499690

  1. Merge the following release PR: chore: release v2.0.2+1.19.4 axieum/minecord#107

image

  1. Notice the actual release tag is different - they all share the root component version of v2.0.2 instead of the component-specific version

image

  1. It then immediately creates a new unversioned release rolling back the version numbers, since the git tags are now misaligned

image
@axieum axieum added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 19, 2023
@axieum axieum mentioned this issue Oct 20, 2023
Closed
@axieum
Copy link
Contributor Author

axieum commented Oct 21, 2023

This caused by including the root component version in the pull-request title, e.g. chore: release v2.0.2+1.20.2.

The line of code that applies the grouped pull request title version to all components:

release-please/src/strategies/base.ts

Line 635 in 1ee162b

const version = pullRequestTitle.getVersion() || releaseData?.version;

@axieum axieum changed the title Proposed component version updates are correct, but after merge, the released versions are different Releasable units always use version from pull request title during manifest release Oct 21, 2023
axieum added a commit to axieum/release-please that referenced this issue Oct 21, 2023
@axieum
fix: releasable units should use version from pull-request body (fixes …
cdaaa65 
…googleapis#2101)
@axieum axieum mentioned this issue Oct 21, 2023
Merged
4 tasks
chingor13 pushed a commit that referenced this issue Oct 26, 2023
@axieum
fix: releasable units should use version from pull-request body (#2102)
db035b7 
Co-authored-by: Jeff Ching <chingor@google.com>

Fixes #2101
@release-please release-please bot mentioned this issue Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@chingor13 @axieum