Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: releasable units should use version from pull-request body (fixes #2101) #2102

Merged
merged 3 commits into from
Oct 26, 2023
Merged

fix: releasable units should use version from pull-request body (fixes #2101) #2102

merged 3 commits into from
Oct 26, 2023

Conversation

axieum
Copy link
Contributor

@axieum axieum commented Oct 21, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2101 🦕

@axieum axieum requested review from a team as code owners October 21, 2023 08:59
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 21, 2023
@chingor13 chingor13 merged commit db035b7 into googleapis:main Oct 26, 2023
10 checks passed
@release-please release-please bot mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Releasable units always use version from pull request title during manifest release
2 participants
@axieum @chingor13