fix: backfill files by commit for rebased PRs #2141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2140 🦕
This has the effect of not associating a PR with any of the commits from a PR that is rebased and merged. Previously it would associate the PR only with the first commit, but this would also add all the files from the PR to that first commit.
A different (or future) solution would be to decouple connecting PRs and files with commits. I considered that but thought that solution would increase the scope too much. I'm open to reworking the PR in that direction though.