Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] release version is tied to PR, not to commit #320

Closed
1 task done
wraithgar opened this issue Jul 5, 2023 · 2 comments
Closed
1 task done

[BUG] release version is tied to PR, not to commit #320

wraithgar opened this issue Jul 5, 2023 · 2 comments

Comments

@wraithgar
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

See npm/cli#6609. Arborist got a semver minor due to a commit that didn't affect it, but was part of a PR that did affect it.

Expected Behavior

Arborist should have gotten a semver minor.

Steps To Reproduce

No response

Environment

No response
@wraithgar wraithgar added Needs Triage needs an initial review and removed Needs Triage needs an initial review labels Jul 5, 2023
@lukekarrys
Copy link
Contributor

Dug into this finally and found it is due to behavior in release-please. I opened a PR to fix this googleapis/release-please#2141. Hopefully that will land and once #334 lands here we can update release-please to get the fix.

@lukekarrys
Copy link
Contributor

This is fixed now after googleapis/release-please#2141 landed in release-please@16.3.1 and #334 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wraithgar @lukekarrys