Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use upstream release-please #334

Merged
merged 2 commits into from
Nov 28, 2023
Merged

feat: use upstream release-please #334

merged 2 commits into from
Nov 28, 2023

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Jul 10, 2023 •
edited
Loading

This also adds 100% test coverage to release-please and release-manager using nock.

Fixes #177

@lukekarrys lukekarrys requested a review from a team as a code owner July 10, 2023 20:14
@lukekarrys lukekarrys force-pushed the lk/nervous-tart-coat branch 3 times, most recently from ba07c1a to d9c3a29 Compare July 10, 2023 20:22
wraithgar
wraithgar previously approved these changes Jul 10, 2023
View reviewed changes
@lukekarrys lukekarrys marked this pull request as draft July 10, 2023 22:34
@lukekarrys lukekarrys changed the title lk/nervous tart coat fix: add correct publish tag for backports Jul 10, 2023
@lukekarrys lukekarrys changed the title fix: add correct publish tag for backports Autopublish for workspaces + nock tests for release please Sep 14, 2023
@lukekarrys lukekarrys mentioned this pull request Nov 8, 2023
Closed
4 tasks
@lukekarrys lukekarrys changed the title Autopublish for workspaces + nock tests for release please Nock tests for release please Nov 8, 2023
@lukekarrys lukekarrys changed the title Nock tests for release please fix: refactor and add tests for release functions Nov 8, 2023
@lukekarrys lukekarrys force-pushed the lk/nervous-tart-coat branch 2 times, most recently from fcb5b54 to 61e2718 Compare November 10, 2023 18:59
@lukekarrys lukekarrys changed the base branch from main to lk/latest-npm November 10, 2023 18:59
@lukekarrys lukekarrys force-pushed the lk/nervous-tart-coat branch 5 times, most recently from 10e669e to 18c0f93 Compare November 14, 2023 21:35
Base automatically changed from lk/latest-npm to main November 15, 2023 21:39
@lukekarrys lukekarrys force-pushed the lk/nervous-tart-coat branch 4 times, most recently from 083c66d to 855f4da Compare November 18, 2023 22:32
@lukekarrys lukekarrys changed the base branch from main to lk/use-chores-plus-more November 18, 2023 22:33
@lukekarrys lukekarrys changed the title fix: refactor and add tests for release functions feat: use upstream release-please Nov 18, 2023
@lukekarrys lukekarrys force-pushed the lk/nervous-tart-coat branch 3 times, most recently from 2f5c040 to ae3e517 Compare November 23, 2023 21:15
@lukekarrys lukekarrys marked this pull request as ready for review November 24, 2023 21:09
@lukekarrys
Copy link
Contributor Author

This is multiple commits because it helped me keep track of coverage and testing changes as I iterated. But this can be squashed and merged to a single commit.

@lukekarrys lukekarrys mentioned this pull request Nov 26, 2023
Closed
1 task
@lukekarrys
Copy link
Contributor Author

This is ready for review but is built on #380 so that will need to be merged first.

@lukekarrys lukekarrys linked an issue Nov 26, 2023 that may be closed by this pull request
Get release-please fork fixes/features merged upstream #177
Closed
6 tasks
Base automatically changed from lk/use-chores-plus-more to main November 27, 2023 22:01
lukekarrys
lukekarrys commented Nov 28, 2023
View reviewed changes
lib/release/release-manager.js Outdated Show resolved Hide resolved
lib/release/release-manager.js Show resolved Hide resolved
lib/release/util.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tap-snapshots/test/release/release-manager-cwd.js.test.cjs Show resolved Hide resolved
@lukekarrys lukekarrys mentioned this pull request Nov 28, 2023
Merged
@lukekarrys lukekarrys force-pushed the lk/nervous-tart-coat branch 2 times, most recently from 7ea6750 to 8ec3bec Compare November 28, 2023 16:56
lukekarrys added a commit that referenced this pull request Nov 28, 2023
@lukekarrys
fix: fallback to default release process of 404 from hosted version (#…
c892260 
…386)

This also fixes the release manager logging since `core.info` only
allows a single string argument.

These changes are not tested because they are all tested in #334. But I
wanted to fix this bug before that gets reviewed.
@lukekarrys
Copy link
Contributor Author

This has been squashed to a single commit and rebased against main. It is ready for review again.

lukekarrys
lukekarrys commented Nov 28, 2023
View reviewed changes
lib/release/release-manager.js
gh pr merge <PR-NUMBER> ${R} --rebase
\`\`\`
${block('sh')}
gh pr merge <PR-NUMBER> ${R} --squash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned that release-please will work faster if the release PRs are merged with squash instead of rebase.

@lukekarrys
fix: make defaultTag required
26c9641 
This more closely aligns the test behavior with how it is actually called.
The release.yml workflow always passed in a tag.
wraithgar
wraithgar reviewed Nov 28, 2023
View reviewed changes
package.json
@@ -19,7 +19,8 @@
"postlint": "template-oss-check",
"postinstall": "template-oss-apply",
"test-all": "npm run test -ws -iwr --if-present",
"lint-all": "npm run lint -ws -iwr --if-present"
"lint-all": "npm run lint -ws -iwr --if-present",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these entries were alphabetical

@lukekarrys lukekarrys merged commit 2daff23 into main Nov 28, 2023
17 checks passed
@lukekarrys lukekarrys deleted the lk/nervous-tart-coat branch November 28, 2023 18:14
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
lukekarrys pushed a commit that referenced this pull request Dec 1, 2023
@github-actions
chore: release 4.21.0 (#385)
d13658b 
🤖 I have created a release *beep* *boop*
---


##
[4.21.0](v4.20.0...v4.21.0)
(2023-12-01)

### Features

*
[`2daff23`](2daff23)
[#334](#334) use upstream
release-please (#334) (@lukekarrys)
*
[`3d76fc4`](3d76fc4)
[#380](#380) release workflow
uses composite actions (#380) (@lukekarrys)

### Bug Fixes

*
[`fbe355c`](fbe355c)
[#388](#388) pin release-please
version (#388) (@lukekarrys)
*
[`4fad5d8`](4fad5d8)
[#387](#387) make prerelease
config switch versioning strategy (#387) (@lukekarrys)
*
[`c892260`](c892260)
[#386](#386) fallback to default
release process of 404 from hosted version (#386) (@lukekarrys)
*
[`9b22b83`](9b22b83)
[#384](#384) give release
integration workflow correct permissions and secrets (#384)
(@lukekarrys)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jun 20, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get release-please fork fixes/features merged upstream
2 participants
@lukekarrys @wraithgar