Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: give release integration workflow correct permissions and secrets #384

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Nov 28, 2023

Since it is now invoked by workflow_call the permissions need to be set by both the caller and callee.

This also only forwards the necessary PUBLISH_TOKEN secret to the workflow instead of all secrets.

The above two things are only applied when publish: true is set.

@lukekarrys lukekarrys requested a review from a team as a code owner November 28, 2023 00:34
@lukekarrys lukekarrys merged commit 9b22b83 into main Nov 28, 2023
18 checks passed
@lukekarrys lukekarrys deleted the lk/release-workflow-permissions branch November 28, 2023 15:56
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
lukekarrys pushed a commit that referenced this pull request Dec 1, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.21.0](v4.20.0...v4.21.0)
(2023-12-01)

### Features

*
[`2daff23`](2daff23)
[#334](#334) use upstream
release-please (#334) (@lukekarrys)
*
[`3d76fc4`](3d76fc4)
[#380](#380) release workflow
uses composite actions (#380) (@lukekarrys)

### Bug Fixes

*
[`fbe355c`](fbe355c)
[#388](#388) pin release-please
version (#388) (@lukekarrys)
*
[`4fad5d8`](4fad5d8)
[#387](#387) make prerelease
config switch versioning strategy (#387) (@lukekarrys)
*
[`c892260`](c892260)
[#386](#386) fallback to default
release process of 404 from hosted version (#386) (@lukekarrys)
*
[`9b22b83`](9b22b83)
[#384](#384) give release
integration workflow correct permissions and secrets (#384)
(@lukekarrys)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants