-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass pull request header and footer options to merge plugin #2143
fix: pass pull request header and footer options to merge plugin #2143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! The feature seems reasonable, but this one has a bit more complex logic and could use a unit test to demonstrate the example and to ensure we don't regress in the future.
2ae5c7f
to
24652d8
Compare
Thanks @chingor13! I added a test case where it grabs the header from the first package and the footer from the second package another, while also ignoring the footer from the second package. Let me know what you think. |
I didn't realize I left the tests in a failing state. Just pushed a fixup that should be passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2142 🦕
Details
This works by looping through
repositoryConfig
and getting the first set value for bothpullRequestHeader
andpullRequestFooter
. This means they could possibly come from different components in a manifest release.Alternate Solutions
I thought about only using config values from
repositoryConfig[ROOT_PROJECT_PATH]
. I didn't have strong feelings either way so I went with the solution I felt would be less surprising. But I'd be open to reworking the PR to this alternate solution.