fix: draft-pull-requests config #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered this issue while using `release-please-action` which builds a config via `Manifest.fromManifest`. In this function the `draftPullRequest` setting from the config from the config defaults was not considered when merging with the package specific configs. As a result, defining this at the top level of the config had no impact. Integration with the action was tested via a fork of the `release-please-action` which was run on a test repo[3] the results can be seen at[4] Fixes: googleapis#1791 [1] https://github.com/google-github-actions/release-please-action/blob/a37ac6e4f6449ce8b3f7607e4d97d0146028dc0b/src/index.ts#L108 [2] matthewhughes934/release-please-action@07de5f3 [3] https://github.com/matthewhughes934/release-please-test/commit/c55af6660b7e67974ed4d9924e4a378c3ab01a7c [4] https://github.com/matthewhughes934/release-please-test/pull/10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this issue while using
release-please-actionwhich builds a config viaManifest.fromManifest. In this function thedraftPullRequestsetting from the config from the config defaults was not considered when merging with the package specific configs. As a result, defining this at the top level of the config had no impact.Integration with the action was tested via a fork of the
release-please-actionwhich was run on a test repo[3] the results can be seen at[4]Fixes: #1791
[1] https://github.com/google-github-actions/release-please-action/blob/a37ac6e4f6449ce8b3f7607e4d97d0146028dc0b/src/index.ts#L108
[2] matthewhughes934/release-please-action@07de5f3
[3] https://github.com/matthewhughes934/release-please-test/commit/c55af6660b7e67974ed4d9924e4a378c3ab01a7c
[4] https://github.com/matthewhughes934/release-please-test/pull/10
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: