Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: draft-pull-requests config #2241

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix: draft-pull-requests config #2241

merged 2 commits into from
Mar 13, 2024

Commits on Mar 13, 2024

  1. fix: draft-pull-requests config 

    I discovered this issue while using `release-please-action` which builds
a config via `Manifest.fromManifest`. In this function the
`draftPullRequest` setting from the config from the config defaults was
not considered when merging with the package specific configs. As a
result, defining this at the top level of the config had no impact.

Integration with the action was tested via a fork of the
`release-please-action` which was run on a test repo[3] the results can
be seen at[4]

Fixes: googleapis#1791

[1] https://github.com/google-github-actions/release-please-action/blob/a37ac6e4f6449ce8b3f7607e4d97d0146028dc0b/src/index.ts#L108
[2] matthewhughes934/release-please-action@07de5f3
[3] https://github.com/matthewhughes934/release-please-test/commit/c55af6660b7e67974ed4d9924e4a378c3ab01a7c
[4] https://github.com/matthewhughes934/release-please-test/pull/10
    @matthewhughes934
    matthewhughes934 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    aac448f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-draft-pull-requests

    @chingor13
    chingor13 authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    63975d6 View commit details
    Browse the repository at this point in the history