Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: add support for __about__.py #2433

Open
fredrikaverpil opened this issue Nov 16, 2024 · 0 comments · May be fixed by #2434
Open

Python: add support for __about__.py #2433

fredrikaverpil opened this issue Nov 16, 2024 · 0 comments · May be fixed by #2434
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@fredrikaverpil
Copy link

fredrikaverpil commented Nov 16, 2024

Is your feature request related to a problem? Please describe.

Release-please attempts to update a Python package's __init__.py with the new version string.

Some Python projects doesn't use __init__.py to store the version string. Some projects like to place this in a __about__.py file instead. It's right now quite cumbersome to make release-please just update any version string inside the __about__.py file, if it exists.

Describe the solution you'd like

I'd like to have release-please support not only __init__.py but also the __about__.py file. The only difference here is the filename.

Describe alternatives you've considered

I've tried to override the manifest's version-file property, as described here. But it does not have any effect, as this variable is not taken into account in https://github.com/googleapis/release-please/blob/main/src/strategies/python.ts

PR proposal to enable use of version-file: #2434

@fredrikaverpil fredrikaverpil added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants