feat(python): read version-file from manifest #2434
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
I wanted to write the version string to
__about__.py
instead of the default__init__.py
file for release-typepython
. Writing the version string to__about__.py
is quite common in the python community.After fiddling around, I noticed that the
version-file
value from the manifest JSON is not read and could've been used so to specify the path to__about__.py
.What was changed?
version-file
value and push the version string to it.version-file
was provided, fall back to previous behavior.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2433