Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: guess python package name by replacing dash to underscore #1230

Conversation

goatwu1993
Copy link
Contributor

@goatwu1993 goatwu1993 commented Jan 18, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1229 🦕

@goatwu1993 goatwu1993 requested a review from a team January 18, 2022 12:02
@goatwu1993 goatwu1993 requested a review from a team as a code owner January 18, 2022 12:02
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can we add a test for this?

@bcoe
Copy link
Contributor

bcoe commented Feb 4, 2022

@goatwu1993 just a friendly nudge, looks like @chingor13 has a couple outstanding questions.

@goatwu1993
Copy link
Contributor Author

I had updated with the set/iteration.

Test is lacking still. I checked the test and seems difficult to use sinom to stub a directory with name with dash replaced with underscore😖.

Any hint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python release type not able to find correct python packages when using poetry
3 participants