Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-workspace): maintain the dependency version prefix in newCandidate #1748

Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix(node-workspace): maintain the dependency version prefix in newCandidate #1748

merged 1 commit into from
Nov 16, 2022

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Nov 14, 2022 •
edited
Loading

In #1723 I overlooked that prefix is also generated in the newCandidate as I incorrectly assumed that that method is only invoked for new packages. It's actually invoked for new updated of any package.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1723 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 14, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 14, 2022
@OrKoN OrKoN changed the title fix(node-workspace): version prefix needs to be maintained in newCandidate too fix(node-workspace): maintain the dependency version prefix in newCandidate Nov 14, 2022
@OrKoN OrKoN marked this pull request as ready for review November 14, 2022 11:39
@OrKoN OrKoN requested a review from a team as a code owner November 14, 2022 11:39
@OrKoN OrKoN requested a review from a team November 14, 2022 11:39
@chingor13 chingor13 merged commit 909d310 into googleapis:main Nov 16, 2022
@release-please release-please bot mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrKoN @chingor13