Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support package-lock.json version 3 #1940

Merged
merged 2 commits into from
May 31, 2023

Conversation

blacha
Copy link
Contributor

@blacha blacha commented May 1, 2023

V3 lock files are backwards compatible with V2 lock files and also need the "" package updated on release.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1939 🦕

V3 lock files are backwards compatible with V2 lock files and also need the `""` package updated on release.

Fixes googleapis#1939
@blacha blacha requested review from a team as code owners May 1, 2023 00:20
@google-cla
Copy link

google-cla bot commented May 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 1, 2023
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the late review

@chingor13 chingor13 enabled auto-merge (squash) May 31, 2023 16:13
@chingor13 chingor13 merged commit 77d80fb into googleapis:main May 31, 2023
@chingor13 chingor13 added the release-please:force-run To run release-please label May 31, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label May 31, 2023
@blacha blacha deleted the fix/package-lock-v3 branch June 1, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"" package in package-lock.json version 3 lock files is not updated
2 participants