Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: require node 18+ #2069

Merged
merged 1 commit into from
Sep 11, 2023
Merged

feat!: require node 18+ #2069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16, 18]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- name: Override NODE options for the most recent version
if: matrix.node == '18'
run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $GITHUB_ENV
- run: node --version
# The first installation step ensures that all of our production
# dependencies work on the given Node.js version, this helps us find
Expand All @@ -36,8 +33,6 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Override NODE options for the most recent version
run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $env:GITHUB_ENV
- run: npm install
- run: npm test
env:
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "./build/src/index.js",
"bin": "./build/src/bin/release-please.js",
"scripts": {
"test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test",
"test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test",
"docs": "echo add docs tests",
"test:snap": "SNAPSHOT_UPDATE=1 LC_ALL=en npm test",
"clean": "gts clean",
Expand Down Expand Up @@ -104,6 +104,6 @@
"yargs": "^17.0.0"
},
"engines": {
"node": ">=14.0.0"
"node": ">=18.0.0"
}
}
Loading