Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect tagSeparator and includeVInTag everywhere #2283

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: respect tagSeparator and includeVInTag everywhere #2283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c69fed
fix: respect `tagSeparator` and `includeVInTag` everywhere
niieani May 5, 2024
d5755c2
Merge branch 'main' into fix-incorrect-release-notes
chingor13 Jun 6, 2024
879e804
Merge branch 'main' into fix-incorrect-release-notes
chingor13 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,12 @@ export class Manifest {
`No latest release found for path: ${path}, component: ${component}, but a previous version (${version.toString()}) was specified in the manifest.`
);
releasesByPath[path] = {
tag: new TagName(version, component),
tag: new TagName(
version,
component,
this.repositoryConfig[path].tagSeparator,
this.repositoryConfig[path].includeVInTag
),
sha: '',
notes: '',
};
Expand Down
7 changes: 6 additions & 1 deletion src/strategies/php-yoshi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,12 @@ export class PHPYoshi extends BaseStrategy {
const versionsMap: VersionsMap = new Map();
const directoryVersionContents: Record<string, ComponentInfo> = {};
const component = await this.getComponent();
const newVersionTag = new TagName(newVersion, component);
const newVersionTag = new TagName(
newVersion,
component,
this.tagSeparator,
this.includeVInTag
);
let releaseNotesBody = `## ${newVersion.toString()}`;
for (const directory of topLevelDirectories) {
try {
Expand Down
Loading