Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: versioning-strategy field incorrect #2450

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

reggi
Copy link

@reggi reggi commented Dec 10, 2024

👋 hi (one of a couple different incoming prs) this is an easy one:

https://github.com/googleapis/release-please/blob/main/src/bin/release-please.ts#L304

The field is "versioning-strategy" not "versioning", also missing "prerelease-type".

@reggi reggi requested review from a team as code owners December 10, 2024 22:28
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 10, 2024
@reggi
Copy link
Author

reggi commented Dec 11, 2024

OK I found out the hard way internals don't use versioning-strategy and actually do use versioning which isn't the actual documented property

--versioning-strategy VersioningStrategyType Override method of determining SemVer version bumps based on commits. Defaults to default

--versioning-strategy VersioningStrategyType Override method of determining SemVer version bumps based on commits. Defaults to default

https://github.com/googleapis/release-please/blob/main/docs/cli.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants