Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owlbot: _DEFAULT_BRANCH not set to default GitHub branch when new container submitted #2098

Closed
bcoe opened this issue Jun 17, 2021 · 0 comments · Fixed by #2170
Closed

owlbot: _DEFAULT_BRANCH not set to default GitHub branch when new container submitted #2098

bcoe opened this issue Jun 17, 2021 · 0 comments · Fixed by #2170
Assignees
@SurferJeffAtGoogle
Labels
bot: owl-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bcoe
Copy link
Contributor

bcoe commented Jun 17, 2021 •
edited
Loading

When the update-pr.yaml job runs, it populates a variable _DEFAULT_BRANCH which is used by templates to set an appropriate default branch for templates.

This does not appear to happen when a new OwlBot.lock update is created:

googleapis/nodejs-local-auth#94

Which results in the templates reverting the branch name back to the default master.

Note: I noticed that if I manually add owlbot:run it fixes the issue, not 100% sure this didn't happen initially on #94.
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 17, 2021
SurferJeffAtGoogle added a commit to SurferJeffAtGoogle/synthtool that referenced this issue Jun 22, 2021
@SurferJeffAtGoogle
feat: add env var DEFAULT_BRANCH_PATH
c703049 
First step to fixing googleapis/repo-automation-bots#2098.

I want to observe the default branch in the first cloud build step,
then pass it to a later step.  However, it can't be passed directly
via an environment variable because steps can't modify their environment
variables and it's not possible to dynamically compose an environment
variable in a cloud-build.yaml.

Therefore, I'll observe the default branch and record it in a file, and
then pass it the file path to the later step.  The contents of the file
may change but the path to the file is constant and can be specified
in cloud-build.yaml.
@SurferJeffAtGoogle SurferJeffAtGoogle mentioned this issue Jun 22, 2021
Merged
SurferJeffAtGoogle added a commit to googleapis/synthtool that referenced this issue Jun 24, 2021
@SurferJeffAtGoogle
feat: add env var DEFAULT_BRANCH_PATH (#1136)
d4a91f8 
First step to fixing googleapis/repo-automation-bots#2098.

I want to observe the default branch in the first cloud build step,
then pass it to a later step.  However, it can't be passed directly
via an environment variable because steps can't modify their environment
variables and it's not possible to dynamically compose an environment
variable in a cloud-build.yaml.

Therefore, I'll observe the default branch and record it in a file, and
then pass it the file path to the later step.  The contents of the file
may change but the path to the file is constant and can be specified
in cloud-build.yaml.
@SurferJeffAtGoogle SurferJeffAtGoogle mentioned this issue Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels
bot: owl-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass default branch name to post processor SurferJeffAtGoogle/repo-automation-bots
3 participants
@chingor13 @bcoe @SurferJeffAtGoogle