Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Owl bot is concatenating commit descriptions into unparseable text #4984

Closed
SurferJeffAtGoogle opened this issue Feb 27, 2023 · 2 comments · Fixed by #4991
Closed

Owl bot is concatenating commit descriptions into unparseable text #4984

SurferJeffAtGoogle opened this issue Feb 27, 2023 · 2 comments · Fixed by #4991
Assignees
@chingor13
Labels
bot: owl-bot priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@SurferJeffAtGoogle
Copy link
Contributor

Example: googleapis/java-mediatranslation#754

Notice lines like END_NESTED_COMMITBEGIN_NESTED_COMMITchore(bazel): update protobuf to v3.21.12.

Source-Link: https://github.com/googleapis/googleapis/commit/d02e58244db5d01607ec2ad52a47e7edce8612f0

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7f1c54153125eb5abd60a32de58cfda6a798a70a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2YxYzU0MTUzMTI1ZWI1YWJkNjBhMzJkZTU4Y2ZkYTZhNzk4YTcwYSJ9
END_NESTED_COMMITBEGIN_NESTED_COMMITchore(deps): Update gapic-generator-java to 2.14.0
PiperOrigin-RevId: 503433217

Source-Link: https://github.com/googleapis/googleapis/commit/c252ad5a80d95515825a2e167c3dec20bcca48af

Source-Link: https://github.com/googleapis/googleapis-gen/commit/488dc64e7fe3bc46c3267c50b9ff8e85f139fe7b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDg4ZGM2NGU3ZmUzYmM0NmMzMjY3YzUwYjlmZjhlODVmMTM5ZmU3YiJ9
END_NESTED_COMMITBEGIN_NESTED_COMMITchore(bazel): update protobuf to v3.21.12
PiperOrigin-RevId: 503267695
@SurferJeffAtGoogle SurferJeffAtGoogle added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. bot: owl-bot labels Feb 27, 2023
@chingor13
Copy link
Contributor

Looking into this

@chingor13
Copy link
Contributor

It's interesting that when adding the 3rd commit (2 nested commit sections), it was added correctly. Adding the 4th commit, mangled the last 2 commit delimiters.

@chingor13 chingor13 mentioned this issue Mar 6, 2023
Merged
chingor13 added a commit that referenced this issue Mar 8, 2023
@chingor13
fix(owlbot): include newlines when there are multiple nested commits (#…
c77f2b7 
…4991)

Fixes #4984

ci: set node version to 14 for unit tests
@release-please release-please bot mentioned this issue Aug 21, 2023
Closed
@release-please release-please bot mentioned this issue Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
bot: owl-bot priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@chingor13 @SurferJeffAtGoogle