Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auto-approve] Add PythonSampleDependency process #4993

Closed
kweinmeister opened this issue Mar 8, 2023 · 0 comments · Fixed by #5002
Closed

[auto-approve] Add PythonSampleDependency process #4993

kweinmeister opened this issue Mar 8, 2023 · 0 comments · Fixed by #5002
Assignees
@sofisl
Labels
bot: auto approve priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@kweinmeister
Copy link
Contributor

kweinmeister commented Mar 8, 2023 •
edited by sofisl
Loading

  • PythonSampleDependency:
    • Checks that the author is 'renovate-bot'
    • Checks that the title of the PR matches the regexp: /^(fix|chore)(deps): update dependency (@?\S*) to v(\S*)$/
    • Each file path must match one of these regexps:
      • /requirements.txt$/
    • The schema should provide enable opting-out of specified packages and or sample directories.
      • Examples:
        • title: "^(fix|chore)\(deps\):(?!.(exception1|exception2)).$"
        • changedFiles: "(?!exception1|exception2).*requirements\.txt$"
      • Ideally, dependency configuration changes can be done directly in auto-approve.yml without requiring changes & approvals to the process in repo-automation-bots.
        • If this cannot be done, then the initial process configuration should exclude airflow from title and /composer/.*requirements.txt from changedFiles.

Pass:
GoogleCloudPlatform/python-docs-samples#9200
GoogleCloudPlatform/python-docs-samples#9093

Fail:
Due to non-Google update: GoogleCloudPlatform/python-docs-samples#9180
Due to impacting /composer: GoogleCloudPlatform/python-docs-samples#9000
@kweinmeister kweinmeister added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. bot: auto approve priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 8, 2023
@kweinmeister kweinmeister removed the priority: p3 Desirable enhancement or fix. May not be included in next release. label Mar 8, 2023
@sofisl sofisl mentioned this issue Mar 16, 2023
Merged
sofisl added a commit that referenced this issue Mar 23, 2023
@sofisl @kweinmeister
feat: [auto-approve] add python sample dependency process (#5002)
8323737 
Fixes #4993 

cc @kweinmeister

---------

Co-authored-by: Karl Weinmeister <11586922+kweinmeister@users.noreply.github.com>
@sofisl sofisl mentioned this issue Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
bot: auto approve priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: [auto-approve] add python sample dependency process googleapis/repo-automation-bots
3 participants
@kweinmeister @SurferJeffAtGoogle @sofisl