feat: [auto-approve] add python sample dependency process #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofisl
changed the title
sofisl
changed the title
chingor13
requested changes
Mar 22, 2023
| @@ -244,8 +244,30 @@ export function doesDependencyChangeMatchPRTitle( | |||
| return false; | |||
| } | |||
|
|
|||
| export function doesDependencyAgainstRegexes( | |||
There was a problem hiding this comment.
Please add a jsdoc to describe what this is doing.
There was a problem hiding this comment.
Also, this could use a test if it's a re-usable helper
Comment on lines
249
to
250
| regexToInclude: RegExp[] | undefined, | ||
| regexToExclude: RegExp[] | undefined |
There was a problem hiding this comment.
These could be optional
Suggested change
| regexToInclude: RegExp[] | undefined, | |
| regexToExclude: RegExp[] | undefined | |
| regexToInclude?: RegExp[], | |
| regexToExclude?: RegExp[] |
| regexToInclude: RegExp[] | undefined, | ||
| regexToExclude: RegExp[] | undefined | ||
| ): boolean { | ||
| let doesDepIncludeRegexToInclude = true; |
There was a problem hiding this comment.
Is this correct? If there are no regexes, then this would return true?
There was a problem hiding this comment.
Exactly! If no regexes are provided, then there's no criteria to check the dependency against; so, it's trivially valid.
There was a problem hiding this comment.
Note: This is a lot of code to implement a new rule that shares much of its logic with other classes.
chingor13
approved these changes
Mar 23, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4993
cc @kweinmeister