Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto-approve] feature requests for compatibility with sample applications #5006

Closed
bourgeoisor opened this issue Mar 20, 2023 · 0 comments · Fixed by #5053
Closed

[auto-approve] feature requests for compatibility with sample applications #5006

bourgeoisor opened this issue Mar 20, 2023 · 0 comments · Fixed by #5053
Assignees
Labels
bot: auto approve priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bourgeoisor
Copy link

bourgeoisor commented Mar 20, 2023

The DevRel team leverages Renovate to keep up-to-date with sample application dependencies but this can quickly become unwieldy. Therefore, I'm looking into leveraging auto-approval (couple with merge-on-green), but a few features are missing for our use cases.

Examples of sample application repositories that we'd like auto-approve help with:

I am happy helping out with creating PRs for these, but wanted to check in first.

1) DockerDependency non-existant

Currently, there are no type for Docker PRs.

Suggestion: Add a new type for this.

Example PR: GoogleCloudPlatform/bank-of-anthos#1356

  • no major bumps
  • renovate
  • no max files
  • always a file named Dockerfile
  • all dependencies match all files and the title of the PR

2) GolangDependency non-existant

Currently, there are no type for Golang PRs.

Suggestion: Add a new type for this.

Example PR: GoogleCloudPlatform/microservices-demo#1597

  • no major bumps
  • renovate
  • no max files
  • always a file in go.sum or go.mod (go.mod always changes in the same ay, go.sum doesn't)
  • all dependencies match all files and the title of the PR

-- Modifications of existing types ---

3) Maximum number of files on all deps too small

The current maximum number of files for each dependency type is set to 3. For sample applications composed of multiple services (and multiple services of the same language) this means that a majority of Renovate PRs could never get auto-approved.

Suggestion: Removing that constraint, or bumping it higher.

Example PR: GoogleCloudPlatform/bank-of-anthos#1355

  • go, python, node, java
  • not merging major,
  • no max files

4) PythonDependency doesn't support .in files

There is currently a constraint that only requirements.txt files are supported for Python dependencies. In some of our repositories, we also use a requirements.in file for package management (see pip-tools).

Suggestion: Adding requirements.in as a valid file matching.

Example PR: GoogleCloudPlatform/bank-of-anthos#1358

5) PythonDependency filepath matching too strict

There is currently a constraint that all filepath must match /^samples/snippets/requirements.txt$/. This is too strict for our repositories, whose Python's dependencies files live in more arbitrary locations.

Suggestion: Removing that constraint.

Example PR: GoogleCloudPlatform/bank-of-anthos#1361

-ends in requirements.txt, or .in

@bourgeoisor bourgeoisor added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. bot: auto approve labels Mar 20, 2023
@bourgeoisor bourgeoisor changed the title [auto-approval] feature requests for compatibility with sample applications [auto-approve] feature requests for compatibility with sample applications Mar 21, 2023
sofisl added a commit that referenced this issue May 16, 2023
Fixes #5006 

cc @bourgeoisor 

- Adds a Go Dependency process
- Adds a Docker Dependency process
- Adds a Python Sample App (specific to the requirements in the bug)
process
- Updates the language for Java Dependency (it was 50, documentation
still said 3)

Will remove the Node Dependency requirement in a F/U PR (the Node team
does not need max files)

---------

Co-authored-by: Jeffrey Rennie <rennie@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: auto approve priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants