[auto-approve] feature requests for compatibility with sample applications #5006
Labels
bot: auto approve
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
The DevRel team leverages Renovate to keep up-to-date with sample application dependencies but this can quickly become unwieldy. Therefore, I'm looking into leveraging auto-approval (couple with merge-on-green), but a few features are missing for our use cases.
Examples of sample application repositories that we'd like auto-approve help with:
I am happy helping out with creating PRs for these, but wanted to check in first.
1) DockerDependency non-existant
Currently, there are no type for Docker PRs.
Suggestion: Add a new type for this.
Example PR: GoogleCloudPlatform/bank-of-anthos#1356
2) GolangDependency non-existant
Currently, there are no type for Golang PRs.
Suggestion: Add a new type for this.
Example PR: GoogleCloudPlatform/microservices-demo#1597
-- Modifications of existing types ---
3) Maximum number of files on all deps too small
The current maximum number of files for each dependency type is set to 3. For sample applications composed of multiple services (and multiple services of the same language) this means that a majority of Renovate PRs could never get auto-approved.
Suggestion: Removing that constraint, or bumping it higher.
Example PR: GoogleCloudPlatform/bank-of-anthos#1355
4) PythonDependency doesn't support .in files
There is currently a constraint that only
requirements.txt
files are supported for Python dependencies. In some of our repositories, we also use arequirements.in
file for package management (see pip-tools).Suggestion: Adding
requirements.in
as a valid file matching.Example PR: GoogleCloudPlatform/bank-of-anthos#1358
5) PythonDependency filepath matching too strict
There is currently a constraint that all filepath must match
/^samples/snippets/requirements.txt$/
. This is too strict for our repositories, whose Python's dependencies files live in more arbitrary locations.Suggestion: Removing that constraint.
Example PR: GoogleCloudPlatform/bank-of-anthos#1361
-ends in requirements.txt, or .in
The text was updated successfully, but these errors were encountered: