Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auto-approve] Add GoApiaryCodegen option #5062

Closed
noahdietz opened this issue May 18, 2023 · 0 comments · Fixed by #5063
Closed

[auto-approve] Add GoApiaryCodegen option #5062

noahdietz opened this issue May 18, 2023 · 0 comments · Fixed by #5063
Assignees
@noahdietz
Labels
bot: auto approve type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@noahdietz
Copy link
Contributor

noahdietz commented May 18, 2023 •
edited
Loading

The Go Apiary client repo had a bespoke auto approve workflow that was used briefly, and attempts to revive it have been a struggle. Instead we should have a GoApiaryCodegen config option, like other languages, and use the auto-approve app on google-api-go-client instead.

The requirements would include the following:

  • the PR comes from the branch discogen there isn't an existing utility for checking this so for simplicity (and matching what Java does) we won't check the origin branch
  • the PR was sent by user yoshi-automation
  • the PR title starts with the "feat(all): auto-regenerate"
@noahdietz noahdietz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. bot: auto approve labels May 18, 2023
@noahdietz noahdietz self-assigned this May 18, 2023
This was referenced May 18, 2023
Merged
Merged
chingor13 pushed a commit that referenced this issue May 18, 2023
@noahdietz
feat(auto-approve): add GoApiaryCodegen option (#5063)
c1adffc 
Adds `GoApiaryCodegen` config option. I copied what was done in some
other config options and the PRs that added them.

Fixes #5062 🦕
@sofisl sofisl mentioned this issue Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
bot: auto approve type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(auto-approve): add GoApiaryCodegen option noahdietz/repo-automation-bots
1 participant
@noahdietz