Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Build Cop): handle flaky tests #285

Merged
merged 2 commits into from
Feb 15, 2020
Merged

feat(Build Cop): handle flaky tests #285

merged 2 commits into from
Feb 15, 2020

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Feb 14, 2020

If the bot reopens an issue, it marks it as flaky then stops commenting
on it and will not close it.

If a flaky test is closed (by a human) then fails again, it will be reopened.

Fixes #281.

If the bot reopens an issue, it marks it as flaky then stops commenting
on it and will not close it.

If a flaky test is closed (by a human) then fails again, it will be reopened.

Fixes #281.
@tbpg tbpg requested review from bcoe, nnegrey and sofisl February 14, 2020 19:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2020
Copy link

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me @tbpg 👌 does the buildcop: flaky tag need to already exist, if so we should add it to label-sync.

@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #285   +/-   ##
======================================
  Coverage    87.6%   87.6%           
======================================
  Files          15      15           
  Lines        2622    2622           
  Branches      249     249           
======================================
  Hits         2297    2297           
  Misses        312     312           
  Partials       13      13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05551ca...abeb82d. Read the comment docs.

@tbpg
Copy link
Contributor Author

tbpg commented Feb 15, 2020

No, it doesn't need to exist. I didn't add buildcop:issue and it seemed to work without a problem.

But, we might want to add it to label-sync regardless to get consistent coloring and descriptions.

@tbpg
Copy link
Contributor Author

tbpg commented Feb 15, 2020

Filed #288.

@tbpg tbpg merged commit 4dd6255 into master Feb 15, 2020
@tbpg tbpg deleted the buildcop branch February 15, 2020 00:38
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
4dd6255
commit 4dd6255
Author: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Date:   Fri Feb 14 19:37:55 2020 -0500

    feat(Build Cop): handle flaky tests (#285)

    If the bot reopens an issue, it marks it as flaky then stops commenting
    on it and will not close it.

    If a flaky test is closed (by a human) then fails again, it will be reopened.

    Fixes #281.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Cop: Flaky Tests are hard to track
4 participants